Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(data-warehouse): fix column typing and remove unnecessary UI #23130

Merged
merged 6 commits into from
Jun 24, 2024
Merged

chore(data-warehouse): fix column typing and remove unnecessary UI #23130

merged 6 commits into from
Jun 24, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jun 20, 2024 •
edited
Loading

Problem

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE requested a review from Gilbert09 June 20, 2024 19:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@EDsCODE EDsCODE merged commit a35266b into master Jun 24, 2024
91 checks passed
@EDsCODE EDsCODE deleted the dw-more-view-fixes branch June 24, 2024 13:13
timgl pushed a commit that referenced this pull request Jun 27, 2024
@EDsCODE @timgl
chore(data-warehouse): fix column typing and remove unnecessary UI (#…
eedbb81 
…23130)

* fix column typing and remove unneessary UI

* typing
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jul 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KeyError: 'SimpleAggregateFunction' /api/projects/{parent_lookup_team_id}/query/ View Issue
  • ‼️ KeyError: 'SimpleAggregateFunction' posthog.tasks.tasks.process_query_task View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gilbert09 Gilbert09 Gilbert09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDsCODE @Gilbert09